yiguolei commented on code in PR #66472:
URL: https://github.com/apache/doris/pull/66472#discussion_r3763192555
##########
be/src/storage/row_cursor.cpp:
##########
@@ -174,8 +174,7 @@ template <bool is_mow>
void RowCursor::encode_key_with_padding(std::string* buf, size_t num_keys,
bool padding_minimal) const {
for (uint32_t cid = 0; cid < num_keys; cid++) {
- auto* column = _schema->column(cid);
- if (column == nullptr) {
+ if (cid >= _schema->num_read_columns()) {
Review Comment:
这种地方都得加点注释，后来人看不明白；AI 也看不明白，也没法review。 注释咱们得英语解释的往往是字面意思，得举个例子
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
