yiguolei commented on code in PR #66472:
URL: https://github.com/apache/doris/pull/66472#discussion_r3764263995
##########
be/src/storage/segment/segment.cpp:
##########
@@ -779,23 +774,23 @@ Status Segment::healthy_status() {
}
}
-// Return the storage datatype of related column to field.
-DataTypePtr Segment::get_data_type_of(const TabletColumn& column,
+DataTypePtr Segment::get_data_type_of(const TabletColumn& read_column, const
DataTypePtr& read_type,
const StorageReadOptions& read_options) {
- const PathInDataPtr path = column.path_info_ptr();
+ const PathInDataPtr path = read_column.path_info_ptr();
// none variant column
if (path == nullptr || path->empty()) {
- return DataTypeFactory::instance().create_data_type(column);
+ return read_type;
Review Comment:
对于non variant column 为什么需要外部传递一个data type 进来，而不是用tablet column 来生成？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
