github-actions[bot] commented on code in PR #66697: URL: https://github.com/apache/doris/pull/66697#discussion_r3766109953
########## regression-test/suites/show_p0/test_show_compute_groups.groovy: ########## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("test_show_compute_groups") { + if (isCloudMode()) { + return + } + + // in non cloud mode, a compute group is a resource group, aka the backend location tag + def groups = sql "SHOW COMPUTE GROUPS" + assertTrue(!groups.isEmpty()) + groups.each { row -> + assertEquals(2, row.size()) + assertTrue(Integer.parseInt(row[1].toString()) > 0) Review Comment: Please assert the exact per-location backend count here (or in the FE test with a deterministic multi-backend setup). `BackendNum` is the main new value produced by `groupingBy(..., counting())`, but `> 0` still passes if the implementation returns a constant `1` or otherwise miscounts multiple backends sharing a tag; the changed FE test also starts the default single backend and checks only row width. A same-tag multi-backend case with an exact expected total would regression-fence the new counting behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
