github-actions[bot] commented on code in PR #64561:
URL: https://github.com/apache/doris/pull/64561#discussion_r3766278448
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/AdminSetEncryptionRootKeyCommand.java:
##########
@@ -81,7 +82,7 @@ public void validate() throws AnalysisException {
throw new AnalysisException("The type field cannot be empty.");
}
try {
- rootKeyInfo.type =
RootKeyInfo.RootKeyType.valueOf(typeValue.toUpperCase());
Review Comment:
`tryFrom` now admits `ranger_kms`, but the common validation below still
rejects a normal Ranger/Hadoop KMS setup unless the caller invents a nonempty
cloud `region`. The new config contract describes Ranger with a Hadoop KMS
endpoint plus Hadoop/Kerberos settings, and validation fails before the
external provider implementation can consume them. Please make the
command-required properties provider-specific—at minimum, do not require
`region` for Ranger—and add a Ranger success case without `region` plus
negative provider-specific coverage. Endpoint/auth validation can remain with
the external implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
