Kikyou1997 commented on code in PR #16114:
URL: https://github.com/apache/doris/pull/16114#discussion_r1082178305
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MergeLimits.java:
##########
@@ -43,11 +42,11 @@
public class MergeLimits extends OneRewriteRuleFactory {
@Override
public Rule build() {
- return
logicalLimit(logicalLimit()).whenNot(Limit::hasValidOffset).then(upperLimit -> {
+ return logicalLimit(logicalLimit()).then(upperLimit -> {
LogicalLimit<? extends Plan> bottomLimit = upperLimit.child();
return new LogicalLimit<>(
Math.min(upperLimit.getLimit(), bottomLimit.getLimit()),
- bottomLimit.getOffset(),
+ bottomLimit.getOffset() + upperLimit.getOffset(),
bottomLimit.child()
Review Comment:
Thanks for your kind reminder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
