gavinchou commented on code in PR #66348:
URL: https://github.com/apache/doris/pull/66348#discussion_r3780726797
##########
be/src/io/fs/azure_obj_storage_client.cpp:
##########
@@ -216,33 +229,40 @@ ObjectStorageResponse
AzureObjStorageClient::put_object(const ObjectStoragePathO
ObjectStorageUploadResponse AzureObjStorageClient::upload_part(const
ObjectStoragePathOptions& opts,
std::string_view stream,
int part_num) {
+ DCHECK(opts.upload_id.has_value());
auto client = _client->GetBlockBlobClient(opts.key);
+ std::string block_id = azure_multipart_block_id(*opts.upload_id, part_num);
Review Comment:
add some comment on "block_id" an "part_num"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
