github-actions[bot] commented on code in PR #66817:
URL: https://github.com/apache/doris/pull/66817#discussion_r3793733554
##########
build.sh:
##########
@@ -1164,7 +1164,6 @@ if [[ "${BUILD_FE}" -eq 1 ]]; then
# Third-party filesystem jars (JuiceFS, JindoFS) are packaged by
post-build.sh
bash "${DORIS_HOME}/post-build.sh" --fe --output "${DORIS_OUTPUT}"
- cp -r -p "${DORIS_HOME}/minidump" "${DORIS_OUTPUT}/fe"/
Review Comment:
[P2] Remove the runner from reused FE outputs
Deleting this copy only fixes a fresh output tree. `build.sh --clean` runs
Maven clean but never clears `${DORIS_OUTPUT}/fe`; FE assembly creates the
directory and clears only `fe/lib`. If a checkout was built at the base
revision, then rebuilt at this head, `output/fe/minidump/` survives and still
ships `nereids_ut.sh`, while the newly copied FE jar no longer has
`Minidump.main`, so the runner still fails at startup. This is distinct from
the earlier fresh-package thread. Please explicitly remove
`${DORIS_OUTPUT}/fe/minidump` during FE assembly (and ideally cover a
reused-output package case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
