ByteYue commented on code in PR #16107:
URL: https://github.com/apache/doris/pull/16107#discussion_r1086313255
##########
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##########
@@ -994,9 +994,10 @@ public static void loadJournal(Env env, JournalEntity
journal) {
* log a warning here to debug when happens. This could happen to
other meta
* like DB.
*/
- LOG.warn("[INCONSISTENT META] replay failed {}: {}", journal,
e.getMessage(), e);
+ LOG.warn("[INCONSISTENT META] replay failed {}: {}", journal,
e.getMessage());
} catch (Exception e) {
- LOG.error("Operation Type {}", opCode, e);
+ LOG.error("Operation Type {}: {}", opCode, e.getMessage());
+ e.printStackTrace();
Review Comment:
Using `printStackTrace` would print the error msg to the stdout, i think it
wouldn't help us debug. We can just log e so it will return the whole stack. If
you are worried about the `Fast Throw` optimization that jvm would do, you can
add `-XX:-OmitStackTraceInFastThrow` in start-fe.sh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
