airborne12 opened a new pull request, #66880:
URL: https://github.com/apache/doris/pull/66880
### What problem does this PR solve?
Issue Number: None
Related PR: #66052
Problem Summary: SNII released the ingestion writer NULL-docid memory charge
before flush, then copied the still-live vector into `LogicalIndexWriter`
without a `Reservation`. A one-million-NULL segment retained a 4 MiB docid
vector while the build reporter observed only about 674 KiB of bitmap scratch,
and the handoff briefly held two complete vectors. This PR carries the existing
move-only vector and `Reservation` through `IndexFileWriter` and
`SniiCompoundWriter`, precharges geometric vector replacements during growth,
and releases the charge only after the NULL bitmap consumes the docids. A real
one-million-NULL compound build verifies reporter current/peak bytes and
terminal zero balance.
### Release note
Reduce and accurately account SNII build memory for NULL-heavy segments.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
`SniiStreamedWriterSessionTest.*`, `SniiSpimiStreamingWriter.*`,
`SniiWriterNullDocids.*`, `SniiWriterFailureLatch.*`, and
`SniiMemoryReporterTest.*` (56 tests); `./build.sh --be -j 192`.
- Behavior changed:
- [ ] No.
- [x] Yes. SNII NULL-docid build memory is transferred without a
duplicate vector and remains accurately accounted during flush.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
