TsukiokaKogane commented on code in PR #66849:
URL: https://github.com/apache/doris/pull/66849#discussion_r3801749407
##########
be/src/storage/iterator/block_reader.cpp:
##########
@@ -255,6 +310,11 @@ Status BlockReader::_min_delta_next_block(Block* block,
bool* eof) {
auto first_op = _read_binlog_op(*_stored_data_columns[_binlog_op_pos],
0);
auto last_op = _read_binlog_op(*_stored_data_columns[_binlog_op_pos],
group_size - 1);
auto result =
binlog::AggregateFunctionMinDelta::calculate_result(first_op, last_op);
+ if (result ==
binlog::AggregateFunctionMinDelta::ResultType::UPDATE_BEFORE_AFTER &&
+ binlog::is_valid_row_binlog_op(first_op) &&
binlog::is_valid_row_binlog_op(last_op) &&
Review Comment:
感觉应该把这块的逻辑挪到下面的switch里 会更工整一些
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
