hello-stephen opened a new pull request, #66897:
URL: https://github.com/apache/doris/pull/66897
### What problem does this PR solve?
Issue Number: None
Related PR: #66789
Problem Summary:
PR #66789 centralized the segment footer magic constants in
`storage/segment/common.h`, but `meta_tool.cpp` still declared the same names
locally in its segment read and write paths. When `BUILD_META_TOOL=ON`, Clang
reports four `-Wshadow` diagnostics and the ASAN build fails because warnings
are treated as errors.
This change includes the defining header explicitly and reuses
`doris::segment_v2::k_segment_magic` and `k_segment_magic_length` in both paths.
### Release note
None
### Check List (For Author)
- Test
- [x] Manual test
- `build-support/clang-format.sh`
- `build-support/check-format.sh`
- `git diff --check`
- Internal ASAN `--meta-tool` validation will be linked after the PR
build finishes.
- Behavior changed:
- [x] No
- Does this need documentation?
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
