HappenLee commented on code in PR #66909:
URL: https://github.com/apache/doris/pull/66909#discussion_r3810020689
##########
be/src/exprs/function/functions_multi_string_search.cpp:
##########
@@ -192,10 +192,11 @@ struct FunctionMultiMatchAnyImpl {
* regular expression matching library.
*
*/
- static Status prepare_regexps_and_scratch(const std::vector<StringRef>&
needles,
- multiregexps::Regexps*& regexps,
- multiregexps::ScratchPtr&
smart_scratch) {
- multiregexps::DeferredConstructedRegexpsPtr
deferred_constructed_regexps =
+ static Status prepare_regexps_and_scratch(
+ const std::vector<StringRef>& needles,
+ multiregexps::DeferredConstructedRegexpsPtr&
deferred_constructed_regexps,
+ multiregexps::Regexps*& regexps, multiregexps::ScratchPtr&
smart_scratch) {
Review Comment:
do not keep raw pointer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
