hubgeter opened a new pull request, #66939:
URL: https://github.com/apache/doris/pull/66939
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
arrow_build_fingerprint() hashed env.sh, vars.sh, download-thirdparty.sh and
build-thirdparty.sh in full, so any unrelated thirdparty edit changed it and
the build failed with "Arrow build fingerprint does not match selected inputs".
The value changed six times in two weeks on master and none of those commits
touched Arrow. Those whole-script inputs also differ between master and
branch-4.1, so the two branches could never agree on a fingerprint even though
they select the same Arrow closure and are meant to share one thirdparty
installation.
Hash only the inputs that determine the Arrow/Paimon output: an explicit
build-schema version, the selected source variables, and the path plus blob of
each applied patch. Including the path keeps patch selection and ordering part
of the contract. Output-affecting build options in build_arrow() and
build_paimon_cpp() are now carried by ARROW_BUILD_SCHEMA_VERSION and
PAIMON_BUILD_SCHEMA_VERSION, which have to be bumped when those options change.
The shared prebuilt in circulation was published with the former
whole-script markers, so keep accepting them, but only while the selected
inputs still hash to the fingerprint the migration was pinned to. Any later
Arrow or Paimon change retires the legacy markers automatically.
This matches the implementation already on branch-4.1, so both branches
compute the same fingerprints and can reuse the same prebuilt.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
