shuke987 opened a new pull request, #66959:
URL: https://github.com/apache/doris/pull/66959
### What problem does this PR solve?
Issue Number: N/A
Related PR: apache/doris-skills#8, apache/doris-skills#9
Problem Summary:
The hosted code-review pipeline can run out of review tokens even when a
committer has already completed the equivalent `doris-repo-review` workflow
locally. Accept a strictly formatted `doris-repo-review/v1` PASS comment as an
alternative source for the existing `code-review` commit status.
The trusted default-branch workflow now:
- accepts only comments authored by users with effective `write` or `admin`
repository permission;
- requires the receipt commit to equal the live PR head;
- requires the reviewed base to equal the live base or be its ancestor by no
more than 48 hours of commit history;
- enforces the exact Opus 5, Fable 5, and GPT-5.6 Sol model allowlist at
`xhigh`, `max`, or `ultra` effort;
- requires `PASS`, convergence, one to three rounds, and zero Blocker/Major
findings;
- writes `code-review: success` only after every check passes.
The 48-hour base rule is evaluated when the comment is created or edited.
Runtime identity remains an auditable local declaration rather than
cryptographic proof, so the existing write-permission boundary and later
sampling remain part of the trust model.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- `python3 .github/scripts/test_validate_review_pass_comment.py` —
24 tests passed
- Parsed `.github/workflows/code-review-sync-result.yml` with
Ruby/Psych
- Validated a generated `doris-repo-review/v1` receipt through the
CLI entry point
- [ ] No need to test or manual test. Explain why:
- Behavior changed:
- [ ] No.
- [x] Yes. A qualified local review receipt can satisfy the existing
`code-review` status for the matching PR head.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
