gavinchou commented on code in PR #66598:
URL: https://github.com/apache/doris/pull/66598#discussion_r3818205271
##########
cloud/src/meta-store/blob_message.h:
##########
@@ -29,6 +31,15 @@ class Message;
namespace doris::cloud {
+inline constexpr size_t DEFAULT_BLOB_SPLIT_SIZE = 90 * 1000;
+
+// Return a split blob key with the encoded version and sequence suffix.
+std::string blob_key(std::string_view key, size_t sequence, uint8_t ver = 0);
Review Comment:
add more comment for each param
##########
cloud/src/meta-store/blob_message.h:
##########
@@ -29,6 +31,15 @@ class Message;
namespace doris::cloud {
+inline constexpr size_t DEFAULT_BLOB_SPLIT_SIZE = 90 * 1000;
+
+// Return a split blob key with the encoded version and sequence suffix.
+std::string blob_key(std::string_view key, size_t sequence, uint8_t ver = 0);
+
+// Decode a split blob key into its origin key, value version, and fragment
sequence.
+bool decode_blob_key(std::string_view raw_key, std::string* origin_key,
uint8_t* version,
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
