BiteTheDDDDt commented on PR #16170: URL: https://github.com/apache/doris/pull/16170#issuecomment-1407541545
In my opinion, `convert_tz` does not need `datev2` as an input parameter, but `day_ceil` accepts datev2 is reasonable. You can remove them all temporarily, and we will investigate what is wrong with the implementation of `day_ceil` in `be` later. For this pr, I think you'd better make some changes in `doris_builtins_functions.py` to ensure that the function signatures of nereids and old planner are consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
