github-actions[bot] commented on code in PR #65658:
URL: https://github.com/apache/doris/pull/65658#discussion_r3819927810
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -518,6 +519,12 @@ void
ExecEnv::init_file_cache_factory(std::vector<doris::CachePath>& cache_paths
config::file_cache_each_block_size,
config::s3_write_buffer_size);
exit(-1);
}
+ auto hdfs_batch_status = io::validate_hdfs_write_batch_buffer_size(
Review Comment:
[P1] Preserve startup compatibility while async writeback is disabled. This
validation runs whenever file cache is enabled, although
`enable_async_file_cache_write` defaults to false. For example,
`file_cache_each_block_size=655360` (640 KiB) still divides the pre-existing
default 5 MiB S3 buffer, but the new check rejects the default 1 MiB HDFS batch
and exits during upgrade—even if the deployment never uses HDFS or async
writeback. The synchronous writer/cache path previously accepted these
arbitrary ranges. The existing noncanonical-layout thread requires the async
reader to tolerate actual cache ranges; remove this unconditional gate once
that is done, or validate/fallback when enabling the dependent async mode
instead of preventing a feature-disabled BE from starting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
