TsukiokaKogane commented on code in PR #66338:
URL: https://github.com/apache/doris/pull/66338#discussion_r3820393978
##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -1610,6 +1610,15 @@ bool SegmentIterator::_need_read_data(ColumnId cid) {
if (_has_delete_predicate(cid)) {
return true;
}
+ // Row-binlog incremental reads force-push the TSO range predicate (see
+ // OlapScanner::_init_tso_pushdown), and the merge iterator uses the TSO
column as its
+ // sequence sort key (BetaRowsetReader sets binlog_tso_idx). On a
cross-version rowset
+ // (e.g. produced by binlog LMax quick-merge) the TSO zonemap can be
always-true, so the
+ // pruning below would skip reading it and fill placeholder zeros,
breaking the merge
+ // ordering. The TSO column carries real values on disk, so force it to be
read.
+ if (_opts.read_row_binlog && cid ==
_opts.tablet_schema->binlog_tso_col_idx()) {
Review Comment:
not important
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
