hoshinojyunn commented on code in PR #66979:
URL: https://github.com/apache/doris/pull/66979#discussion_r3821918361
##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -3806,7 +3812,8 @@ void
SegmentIterator::_prepare_score_column_materialization() {
IColumn::MutablePtr result_column;
auto result_row_ids = std::make_unique<std::vector<uint64_t>>();
- if (_score_runtime->get_limit() > 0 && _col_predicates.empty() &&
+ if (_opts.delete_condition_predicates->num_of_column_predicate() == 0 &&
Review Comment:
In fact, only rowsets with a version less than the delete predicate will
follow the full materialization path, while rowsets with a version greater than
the delete predicate will follow the topN path normally. The performance loss
of the former is paid for correctness and is within expectations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
