jackwener commented on code in PR #16192:
URL: https://github.com/apache/doris/pull/16192#discussion_r1089896553
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/util/OutputUtils.groovy:
##########
@@ -62,6 +62,10 @@ class OutputUtils {
if (expectNull != actualNull) {
return "${info}, line ${line}, ${dataType} result
mismatch.\nExpect cell: ${expectCell}\nBut real is: ${realCell}"
+ } else if (expectCell.contains("nan") ||
expectCell.contains("inf")) {
+ return expectCell == realCell
+ ? null
+ : "${info}, line ${line}, ${dataType} result
mismatch.\nExpect cell: ${expectCell}\nBut real is: ${realCell}"
Review Comment:
```suggestion
Boolean actualNaN = realCell.equals("nan")
Boolean expectInf = expectCell.equals("inf")
Boolean actualInf = realCell.equals("inf")
if (expectNull != actualNull || expectNaN != actualNaN ||
expectInf != actualInf) {
return "${info}, line ${line}, ${dataType} result
mismatch.\nExpect cell: ${expectCell}\nBut real is: ${realCell}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
