924060929 commented on code in PR #66914:
URL: https://github.com/apache/doris/pull/66914#discussion_r3838736046
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergProcedureOps.java:
##########
@@ -230,6 +249,15 @@ private List<ConnectorRewriteGroup>
planInAuthScope(IcebergTableHandle handle,
return
groups.stream().map(IcebergProcedureOps::toConnectorRewriteGroup).collect(Collectors.toList());
}
+ private <T> T withCatalogLease(Supplier<T> operation) {
+ if (resourceTracker == null) {
+ return operation.get();
+ }
+ try (IcebergCatalogResourceTracker.TrackedResource<T> tracked =
resourceTracker.load(operation)) {
Review Comment:
已修复。procedure/rewrite 路径加载的 Table 现在是 operation-owned tracked
resource，finally 中按 catalog flavor 清理 Glue/S3Tables/独立 REST FileIO，并保留 catalog
lease 到操作终止。
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergConnectorMetadata.java:
##########
@@ -2319,6 +2368,13 @@ private static int getFormatVersion(Table table) {
return formatVersion;
}
+ private <T> T executeAuthenticated(Callable<T> operation) throws Exception
{
+ if (resourceTracker == null) {
+ return context.executeAuthenticated(operation);
+ }
+ return resourceTracker.call(() ->
context.executeAuthenticated(operation));
Review Comment:
已修复。Iceberg DDL 的 load/create table 路径统一由 operation-owned table cleanup
包裹，成功和异常路径都会释放表级 FileIO；相关 DDL 成功/失败测试已覆盖。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
