nooneuse commented on code in PR #66307:
URL: https://github.com/apache/doris/pull/66307#discussion_r3882553586
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java:
##########
@@ -410,10 +461,27 @@ public void alterCatalogComment(String catalogName,
String comment) throws UserE
* Modify the catalog property and write the meta log.
*/
public void alterCatalogProps(String catalogName, Map<String, String>
newProperties) throws UserException {
+ CatalogIf<?> catalog = getCatalog(catalogName);
+ if (!(catalog instanceof ExternalCatalog)) {
+ alterCatalogPropsInternal(catalogName, newProperties, catalog);
+ return;
+ }
+ try (ExternalCatalog.ConstraintMetadataMutationGuard ignored =
Review Comment:
okay
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/MetastoreEventSyncDriver.java:
##########
@@ -285,8 +363,28 @@ private void applyOne(PluginDrivenExternalCatalog catalog,
Connector connector,
catalogMgr.registerExternalTableFromEvent(after.localDbName,
after.remoteTableName, after.localTableName,
catalogName, descriptor.getUpdateTime());
+ TableNameInfo oldTable =
+ new TableNameInfo(catalogName, before.localDbName,
before.localTableName);
+ TableNameInfo newTable =
+ new TableNameInfo(catalogName, after.localDbName,
after.localTableName);
+ if (applyConstraintChanges) {
+ if (persistConstraintChanges) {
+ applyPersistedConstraintMutation(
+
ConstraintManager.MetastoreConstraintMutation.renameTable(oldTable, newTable),
Review Comment:
right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
