mrhhsg commented on PR #67343: URL: https://github.com/apache/doris/pull/67343#issuecomment-5495755414
Scope reduced at 0b0428f: this PR now only contains the command-layer fix — `SHOW DICTIONARIES` filtering (with the early return for an empty visible set), the `SHOW` gate on `EXPLAIN DICTIONARY`, and the `LOAD` preflight on `REFRESH DICTIONARY` — plus the `auth_call/test_ddl_dictionary_auth` cases for them (4 files, +113/-4). Everything that grew out of the review rounds around **reading** dictionary values — the `dict_get()` / `dict_get_many()` `SELECT` check with its bind-time placement and persisted-view / alias-function scope, the sql-cache and short-circuit point-query exclusions, and the column-aware / resolved-table source preflight of `REFRESH` — is a separate problem (dictionary values were never authorized, independently of this metadata leak) and has been moved out to a follow-up PR so that it can be reviewed with its design in front, together with #67345. The earlier "Fixed in …" replies on those threads refer to that follow-up, not to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
