github-actions[bot] commented on code in PR #67218:
URL: https://github.com/apache/doris/pull/67218#discussion_r3914668213
##########
be/test/exprs/function/function_string_test.cpp:
##########
@@ -87,6 +87,7 @@ TEST(function_string_test,
function_auto_partition_name_case_insensitive_test) {
const DataSet list_data_set = {
{{std::string("LIST"), std::string("edc_server2")},
std::string("pedc5fserver211")},
{{std::string("LiSt"), std::string("edc_server2")},
std::string("pedc5fserver211")},
+ {{std::string("LIST"), std::string("10")}, std::string("p102")},
Review Comment:
[P1] Make the regression match the claimed crash
Tracing this row through the authoritative base shows that it already
returns `p102`: both inputs are `Consted`, the generic wrapper executes one
row, the old implementation lowercases `LIST` and takes the LIST branch, and
padded offset `-1` is valid for the first value. The only new base-failing case
below is the malformed two-argument RANGE call, which exercises a different
out-of-bounds path. As written, the tests therefore do not prove the PR's
stated `auto_partition_name('list', '10')` crash or that its actual cause is
fixed. Please add a regression that reproduces the real failing runtime shape
(ideally end to end plus a targeted BE/ASAN case), or correct the problem
statement if the defect is the malformed RANGE dispatch, and cover the
validation path that actually failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
