Gabriel39 commented on code in PR #67166:
URL: https://github.com/apache/doris/pull/67166#discussion_r3915838603
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergConnectorMetadata.java:
##########
@@ -1336,7 +1336,8 @@ private DorisConnectorException
upgradeNestedModifyError(IcebergTableHandle hand
try {
Types.NestedField current = executeAuthenticated(() ->
catalogOps.withTable(handle.getDbName(),
handle.getTableName(),
- table ->
table.schema().findField(column.getName())));
+ table ->
IcebergNestedColumnEvolution.findTopLevelField(
Review Comment:
Fixed. Nested MODIFY now passes the full ConnectorColumnPath to the
parity-error upgrader and resolves the canonical nested target before comparing
types. Missing or invalid targets remain best-effort and keep the original
build error. Added an InMemoryCatalog regression with Root.Leaf ARRAY<INT> plus
a top-level LEAF ARRAY<FLOAT> decoy.
##########
fe/fe-type/src/main/java/org/apache/doris/catalog/Type.java:
##########
@@ -526,7 +526,7 @@ public String hideVersionForVersionColumn(
StructType structType = (StructType) this;
for (int i = 0; i < structType.getFields().size(); i++) {
StructField field = structType.getFields().get(i);
- StringBuilder desc = new
StringBuilder(field.getName()).append(":")
+ StringBuilder desc = new
StringBuilder(field.getOriginalName()).append(":")
Review Comment:
Fixed. Nereids now rewrites a resolved STRUCT string selector to the field
normalized runtime name before thrift/BE translation, for both element_at and
dotted dereference, while metadata display keeps the original spelling. Added
analyzer coverage for Σ to σ and ẞ to ß, plus an external Iceberg regression
that DESCRIBEs and queries the exact displayed spellings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
