morningman commented on PR #67442:
URL: https://github.com/apache/doris/pull/67442#issuecomment-5519769196
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67442
commit: de5a2dd2b4d998e8515de555e80a3897c7a561ee
base: 049410596f4d8c0a5c23bb5519e6b8f09dc63ab4
reviewed_at: 2026-09-03T11:12+08:00
reviewer: morningman
model: claude-fable-5-1
effort: max
findings: {blocker: 0, major: 0, minor: 1, nit: 6}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/test/load/memtable/memtable_flush_executor_test.cpp:624` — the new
tests wait for task-object destruction with fixed sleeps and unbounded `while
(cnt == 0) sleep` loops; `pool->wait()` is deterministic here because
`dispatch_thread` resets the runnable (`threadpool.cpp:628`) before it
decrements `_active_threads` (`threadpool.cpp:667`).
- `be/src/load/memtable/memtable_flush_executor.cpp:124` — the map entry is
erased before the memtable tracker scopes below it; on the not-consumed paths
the node allocated under `memtable->mem_tracker()` is freed under another
tracker (few-byte residue, fatal only with
`crash_in_memory_tracker_inaccurate`). Moving the two `SCOPED_*` guards above
the `if` fixes it.
- `be/src/load/memtable/memtable_flush_executor.cpp:190` — `_memtable2block`
now treats "map != nullptr" as `need_allocated_lsn()`; true today (single
producer `GroupRowsetWriter::init`, both builders pass a fresh data-writer
ctx), worth pinning with a `DCHECK_EQ` here.
- `be/src/load/memtable/memtable_flush_executor.h:31` — a forward
declaration of `segment_v2::SegmentAllocatedLsnMap` would do instead of
including `storage/binlog.h`; the old `struct RowsetWriterContext;` forward
declaration is now unused.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
