morrySnow commented on code in PR #14397:
URL: https://github.com/apache/doris/pull/14397#discussion_r1093164371
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -1730,6 +1853,77 @@ private Optional<DataPartition>
toDataPartition(PhysicalDistribute distribute,
}
}
+ private Map<ExprId, SlotRef> getBufferedSlotRefForWindow(WindowFrameGroup
windowFrameGroup,
+
PlanTranslatorContext context) {
+ Map<ExprId, SlotRef> bufferedSlotRefForWindow =
context.getBufferedSlotRefForWindow();
+ // will be set only once when visiting first PhysicalWindow
Review Comment:
i don't think it is right. for example:
```sql
select
count(1) over (...)
from (
select *
from
a
join (select count(1) over (...) from b) c on a.c1 = c.c1
) d;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
