github-actions[bot] commented on code in PR #67622:
URL: https://github.com/apache/doris/pull/67622#discussion_r3954565427
##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserProperty.java:
##########
@@ -223,8 +223,9 @@ public void update(List<Pair<String, String>> properties,
boolean isReplay) thro
throw new DdlException(PROP_MAX_USER_CONNECTIONS + " is
not number");
}
- if (newMaxConn <= 0 || newMaxConn > 10000) {
- throw new DdlException(PROP_MAX_USER_CONNECTIONS + " is
not valid, must between 1 and 10000");
+ // No need to set an upper bound for newMaxConn,
ConnectPoolMgr limits it at runtime.
Review Comment:
The runtime fallback is stale for Arrow Flight SQL.
`FlightTokenManagerImpl.createToken` creates `usersTokenLRU[username]` only
once with `maximumSize(getMaxConn(username) / 2)` (the adjacent TODO notes
property changes do not resize it), while
`FlightSqlConnectPoolMgr.registerConnection` explicitly skips the per-user
check. With both Flight global limits above 15000, if the first token is
created at the default 100 and this statement then sets 15000, the cache
remains size 50; creating token 51 evicts the least-recently-used existing
token and tears down that live session despite global room. Starting at 15000
and lowering to 100 likewise leaves a size-7500 cache. Since this change newly
permits values above 10000 by relying on runtime enforcement, please make the
Arrow path consult/update the current property and test both directions after
the per-user cache already exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
