starocean999 commented on code in PR #67668:
URL: https://github.com/apache/doris/pull/67668#discussion_r3966163464
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Max.java:
##########
@@ -37,7 +37,8 @@
/** max agg function. */
public class Max extends NullableAggregateFunction
- implements UnaryExpression, CustomSignature, SupportWindowAnalytic,
RollUpTrait {
+ implements UnaryExpression, CustomSignature, SupportWindowAnalytic,
RollUpTrait,
+ NullIgnoringAggregateFunction {
Review Comment:
max and min agg function accept null value. for example max(null) -> null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
