yiguolei commented on code in PR #67701:
URL: https://github.com/apache/doris/pull/67701#discussion_r3968721029
##########
be/src/service/CMakeLists.txt:
##########
@@ -64,21 +64,18 @@ if (${MAKE_TEST} STREQUAL "OFF" AND ${BUILD_BENCHMARK}
STREQUAL "OFF")
endif ()
pch_reuse(doris_be)
- # This permits libraries loaded by dlopen to link to the symbols in the
program.
- set_target_properties(doris_be PROPERTIES ENABLE_EXPORTS 1)
-
- # ...but not the symbols of the RocksDB we link statically. Exporting
those makes this
- # executable the definition every later-loaded library binds to, and a JNI
library that
- # carries its own RocksDB then runs half on ours: the fluss scanner
bundles frocksdbjni,
- # whose librocksdbjni.so defines 2576 rocksdb symbols under names
identical to ours but
- # was built against the pre-C++11 libstdc++ string ABI. Objects laid out
by one and used
- # by the other yield a garbage length, an std::bad_alloc that escapes the
JNI frame, and
- # an aborted BE. Hiding this archive lets that library bind to its own
copy.
- #
- # Scoped to the archive rather than dropping ENABLE_EXPORTS: what needs
the exports is
- # native UDFs (runtime/user_function_cache.cpp dlopens them), and those
use the Doris UDF
- # ABI, which has nothing to do with RocksDB. Crash stacks do not need it
either -- they are
- # symbolized from debug info, which is why they name even
anonymous-namespace functions.
+ # Keep doris_be symbols private. Java UDF callbacks are registered
explicitly through JNI and
Review Comment:
It is an old problem already exsits in the previous version. And it only
happens when set STRIP_DEBUG_INFO=ON, but actually doris always set
STRIP_DEBUG_INFO=OFF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
