mrhhsg commented on PR #67757:
URL: https://github.com/apache/doris/pull/67757#issuecomment-5612710819
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67757
commit: 4f0982b3d6d641103af451848bef138f1319f2d8
base: 7129a3e8c6bf087cb5a3a818e53343f5fee2c297
reviewed_at: 2026-09-10T11:57+08:00
reviewer: mrhhsg
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 2}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/test/storage/segment/column_reader_test.cpp:993` —
`LegacyStructOffsetComponentRoutesToDataField` asserts only that one path
reached the `offset` child; asserting the forwarded payload (type DATA, legacy
version, path `{"offset"}`) would also pin the encoding. Nit.
- `be/test/storage/segment/column_reader_test.cpp:958` — nested legacy
shapes (`[arr, *, offset]`, `[m, *, offset]`) are the same defect one level
down and are not unit-tested; the mechanism is level-independent, so this is a
Nit.
- The regression additions run against the new FE and exercise the typed
protocol only; the legacy (old-FE) branch fixed here is covered by the BE unit
test, which also fails on the base code.
- Typed META `OFFSET` on a Struct now returns InternalError; verified
unreachable from the current FE (OFFSET suffix is only emitted by `visitLength`
/ `visitMapSize` / `visitCardinality` with string/map/array type guards).
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
