airborne12 opened a new pull request, #67808:
URL: https://github.com/apache/doris/pull/67808
### What problem does this PR solve?
Related PR: #67537
Problem Summary:
The SNII code and tests touched by #67537 contain Chinese comments and
golden-corpus diagnostics. Translate that explanatory text to English,
including the related FE policy and protobuf comments. Preserve all Unicode
test inputs, executable logic, query expectations, and the on-disk format.
Also clarify two comments against the existing behavior: the control-byte
sample is not the full internal marker, and missing golden expectations fail
verification.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [x] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
Validation:
- Tokenized C++/Java/Protobuf comparison of all 51 changed files: executable
tokens are unchanged except seven translated test diagnostics; Unicode input
data is preserved.
- Source scan: no Chinese comments remain in the changed files.
- Full merged-tree C++ clang-format 16 check passed across BE and Cloud
sources/tests.
- Full merged-tree FE `mvn clean checkstyle:check` passed with JDK 17 and
zero violations.
- `bash build-support/check-build-hygiene.sh` and `git diff --check` passed.
- No database build, unit-test execution, or regression cluster was needed
for these comment/diagnostic-only edits.
- Behavior changed:
- [x] No. Only comments and test diagnostic wording change.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
