924060929 commented on code in PR #67177:
URL: https://github.com/apache/doris/pull/67177#discussion_r3978538043
##########
be/src/exec/pipeline/pipeline_fragment_context.cpp:
##########
@@ -769,13 +769,8 @@ Status
PipelineFragmentContext::_create_deferred_local_exchangers() {
sender_count, _num_instances, info.free_blocks_limit);
break;
case TLocalPartitionType::PASS_TO_ONE:
- if (_runtime_state->enable_share_hash_table_for_broadcast_join()) {
- info.shared_state->exchanger =
PassToOneExchanger::create_unique(
- sender_count, _num_instances, info.free_blocks_limit);
- } else {
- info.shared_state->exchanger =
BroadcastExchanger::create_unique(
- sender_count, _num_instances, info.free_blocks_limit);
- }
+ info.shared_state->exchanger = PassToOneExchanger::create_unique(
Review Comment:
Resolved by narrowing the compatibility scope instead of adding an execution
version. FE-planned local shuffle is master-only and has not shipped on a
release branch. In the supported BE-first rolling upgrade, the released old FE
does not serialize these LocalExchangeNodes; the upgraded BE still uses its
native planner, which now directly selects PASS_TO_ONE for shared broadcast
hash tables and BROADCAST for private ones. The transient master FE/BE wire
behavior is therefore not treated as a release upgrade contract. The final diff
removes all execution-version plumbing and keeps the factories literal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
