superdiaodiao commented on PR #65698: URL: https://github.com/apache/doris/pull/65698#issuecomment-5620280532
Thanks — and CI now backs that up, which is the useful part of this run. `NonConcurrent Regression` passed on the rebased branch (the suite is tagged `nonConcurrent`), so the test asserts `N/A` against current master with no production code in the PR at all. That turns "intended behavior" from a stated intent into something pinned: if the base-table cache is ever reintroduced, this fails loudly instead of the staleness going unnoticed the way it did before #67173. That's why I think it's worth keeping rather than closing. #67173 made the behavior correct but shipped with `test_olap_table_stream_schema_sync.groovy` only, which covers schema sync rather than base-table removal; the sole place `N/A` is asserted against `table_streams` today is a `cloud_p0` suite, which this complements rather than duplicates since it skips cloud mode. Everything is green — P0, NonConcurrent, cloud_p0, External Regression, FE UT, coverage. Would you be willing to approve it so it can go in? Separately: #65389 describes exactly the symptom #67173 fixed and is still open (#67173 closed #67095 and #67109). Probably worth closing it out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
