HappenLee commented on code in PR #67805:
URL: https://github.com/apache/doris/pull/67805#discussion_r3981625204
##########
be/src/exprs/aggregate/aggregate_function_linear_histogram.h:
##########
@@ -90,8 +91,14 @@ struct AggregateFunctionLinearHistogramData {
return;
}
- interval = rhs.interval;
- offset = rhs.offset;
+ if (interval == 0) {
+ interval = rhs.interval;
+ offset = rhs.offset;
+ } else if (UNLIKELY(interval != rhs.interval || offset != rhs.offset))
{
Review Comment:
The missing constant/finite parameter validation and the per-row parameter
overwrite both predate this PR. We will address these existing linear_histogram
parameter-validation issues together in a follow-up change. No additional fix
for this issue will be included in this PR; leaving the thread unresolved to
track the deferred work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
