924060929 commented on code in PR #66913:
URL: https://github.com/apache/doris/pull/66913#discussion_r3978173625
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/metacache/MetaCacheEntry.java:
##########
@@ -107,7 +118,12 @@ public MetaCacheEntry(String name, @Nullable Function<K,
V> loader, CacheSpec ca
maxSize,
true,
null);
- this.loadingData =
cacheFactory.buildCache(this::loadFromDefaultLoader, refreshExecutor);
+ if (removalListener != null) {
+ this.loadingData = cacheFactory.buildCacheWithAsyncRemovalListener(
Review Comment:
Fixed in 7edfc0ba0d3. Hudi filesystem-view values now keep independent cache
and loader ownership. Cache removal releases only cache ownership, while the
loading caller keeps the loader owner until it has acquired the exact lease.
Rejected or unpublished loads retire both owners, and no new lease can be
acquired after both owners retire. Added deterministic removal-before-handoff
coverage plus complete ownership lifecycle tests.
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergScanNode.java:
##########
@@ -782,7 +785,7 @@ public TableScan createTableScan() throws UserException {
this.pushdownIcebergPredicates.add(predicate.toString());
}
- icebergTableScan =
scan.planWith(source.getCatalog().getThreadPoolWithPreAuth());
+ icebergTableScan = scan.planWith(planningExecutor);
Review Comment:
Fixed in 7edfc0ba0d3. Iceberg async planning now retains the exact statement
table generation before executor handoff and registers one owned task with
SplitAssignment. Cancellation makes queued tasks no-op, interrupts running
work, and releases the generation only from the worker terminal path. Added
deterministic tests for running, queued, and submit-window cancellation races.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
