u70b3 commented on PR #67630: URL: https://github.com/apache/doris/pull/67630#issuecomment-5635777574
Response plan per point: **P1 – gate mutability (Config)**: keeping `mutable=true` for now. This flag is the same control the dispatch and FORCE_RELEASE slices will exercise as the production gate (roadmap: https://github.com/apache/doris/issues/66497#issuecomment-5595163744). For this slice the boundary is default-off + EXPERIMENTAL + the admission-time positive-quota assertion, and the external regression suite enables it via ADMIN SET FRONTEND CONFIG. If a hard lock is still preferred, `mutable=false` can land together with the FORCE_RELEASE slice instead of freezing the seam twice. **P1 – storage-routing identity (CatalogMgr)**: agreed — the endpoint-family keys the Lance catalog property chain actually consumes will join the target identity guard; access keys and tokens stay rotatable. **P1 – SHOW authorization (both comments)**: agreed — target resolution becomes exception-safe (any provider lookup failure counts as an unresolved target, so non-ADMIN callers learn nothing and ADMIN still sees the orphan row), and authorization will additionally revalidate the job's persisted locator against the catalog's currently resolved dataset target. **P1 – fixed-list contract vs pinned SDK**: verifying empirically against a real local dataset on the pinned 9.1.0-beta.3 before choosing between narrowing the contract facts and an SDK-side path; findings will follow here. **P2s**: column case-collision fail-closed under the table-lookup relation, `num_bits=8` as the request-side default in the IF comparison, same path-segment representation on both sides of the column comparison, UUID check before the system-entry filter, numeric schema-fact validation (negative ids, non-positive dimensions), `FROM` database-name canonicalization, and `masterOnly` for the two ANN bounds — all accepted, landing in the next push. **P2 – regression quota consumption**: the regression pipeline FE is per-run disposable, so CI runs don't accumulate; the suite will adopt the RESOLVE-based cleanup as soon as PR3E (#67754) lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
