HappenLee commented on code in PR #67805:
URL: https://github.com/apache/doris/pull/67805#discussion_r3993496783
##########
be/src/exprs/aggregate/aggregate_function_group_concat.h:
##########
@@ -73,6 +74,10 @@ struct AggregateFunctionGroupConcatData {
separator = rhs.separator;
data.assign(rhs.data);
} else {
+ if (UNLIKELY(separator != rhs.separator)) {
Review Comment:
Agreed to address this in a follow-up. We have confirmed the gap in both
`_state` and `_combine`, including `_union` followed by `_merge`: states with
different separators merge silently, and equal values with different separators
can appear twice in the result.
The fix needs consistent configuration validation in the distinct wrapper
across merging, serialization and reset. We will handle that separately and
keep this thread open to track the remaining work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
