924060929 commented on code in PR #67790:
URL: https://github.com/apache/doris/pull/67790#discussion_r3996614649


##########
regression-test/suites/nereids_rules_p0/merge_one_row_relation/merge_one_row_relation_into_union.groovy:
##########
@@ -28,4 +28,61 @@ suite("merge_one_row_relation_into_union") {
         ) u
         GROUP BY v
     """
+
+    test {

Review Comment:
   These four cases have deterministic result sets, so please express them as 
named `qt_*`/`order_qt_*` cases and generate the corresponding `.out` baseline 
with the regression runner. The Doris regression-test convention explicitly 
avoids `test { check { assertEquals(...) } }` for determined query results; 
using the golden output also makes future result changes visible in review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to