github-actions[bot] commented on code in PR #67886: URL: https://github.com/apache/doris/pull/67886#discussion_r4002044415
########## fe/fe-core/src/main/java/org/apache/doris/nereids/properties/UnionDataTraitUtils.java: ########## @@ -0,0 +1,283 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.properties; + +import org.apache.doris.nereids.CascadesContext; +import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext; +import org.apache.doris.nereids.trees.expressions.Alias; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.NamedExpression; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.SlotReference; +import org.apache.doris.nereids.trees.expressions.literal.BooleanLiteral; +import org.apache.doris.nereids.trees.expressions.literal.DateLiteral; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.trees.expressions.literal.NumericLiteral; +import org.apache.doris.nereids.trees.expressions.literal.StringLikeLiteral; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.trees.plans.algebra.Union; +import org.apache.doris.nereids.util.ExpressionUtils; +import org.apache.doris.nereids.util.TypeCoercionUtils; +import org.apache.doris.qe.ConnectContext; + +import java.math.BigDecimal; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Optional; +import java.util.Set; + +/** Shared equal-set derivation for logical and physical union plans. */ +public final class UnionDataTraitUtils { + + private UnionDataTraitUtils() { + } + + /** Compute output equal pairs that hold for every row source of a union. */ + public static void computeEqualSet(Union union, Plan unionPlan, DataTrait.Builder builder) { + List<Slot> outputs = unionPlan.getOutput(); + List<Plan> children = unionPlan.children(); + List<List<SlotReference>> childrenOutputs = union.getRegularChildrenOutputs(); + List<List<NamedExpression>> constantRows = union.getConstantExprsList(); + if (outputs.size() < 2 || (children.isEmpty() && constantRows.isEmpty())) { + return; + } + if (children.size() != childrenOutputs.size()) { Review Comment: [P2] Fail fast on malformed union mappings A child/mapping count mismatch is an internal plan-invariant violation: binding and every rewrite path are expected to preserve one mapped list per child and one expression per union output. The same applies to the mapped-width and constant-row-width checks below. Returning here silently lets a corrupt union continue until translation with misaligned result-expression lists, which conflicts with the repository's fail-fast/no-defensive-continuation rule. Please enforce these structural shapes with `Preconditions` (or equivalent), while keeping only legitimate unsupported coercion/folding cases as conservative "no equality proof" outcomes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
