github-actions[bot] commented on code in PR #67881:
URL: https://github.com/apache/doris/pull/67881#discussion_r4003054461
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalHashAggregate.java:
##########
@@ -409,7 +407,7 @@ private boolean isUniformGroupByUnique(NamedExpression
namedExpression) {
return false;
}
Expression agg = namedExpression.child(0);
- return agg instanceof Count || agg instanceof Ndv;
+ return ExpressionUtils.isUniformAgg(agg);
Review Comment:
Make the physical uniform check mode-aware or remove it
Implementation rules produce `Alias(AggregateExpression(...))`, so
`namedExpression.child(0)` here is a wrapper rather than a direct
`Count`/`Ndv`; this new call therefore never applies the shared proof to normal
physical outputs, and the added line is the only uncovered FE line in the
current incremental-coverage report. A blanket `getFunction()` unwrap is not
safe either: `NDV` buffer modes serialize value-dependent HLL states, and a
`BUFFER_TO_RESULT` count can merge one partial row per key whose buffers
summarize different row counts. Please either remove the ineffective physical
hunk/claim, or unwrap only an individual `AggregateExpression` whose mode is
exactly `INPUT_TO_RESULT`, with physical recomputation tests covering
nullable/non-null result cases and buffer modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
