github-actions[bot] commented on code in PR #67494: URL: https://github.com/apache/doris/pull/67494#discussion_r4003101205
########## be/src/cloud/config.cpp: ########## @@ -88,7 +88,8 @@ DEFINE_mBool(enable_sync_tablet_delete_bitmap_by_cache, "true"); DEFINE_mInt32(delete_bitmap_store_write_version, "1"); DEFINE_mInt32(delete_bitmap_store_read_version, "1"); DEFINE_mBool(enable_delete_bitmap_store_v2_check_correctness, "false"); -DEFINE_mInt64(delete_bitmap_store_v2_max_bytes_in_fdb, "1024"); // TODO change default value +// Leave room for DeleteBitmapStoragePB overhead to fit within blob_put's 90000-byte split size. +DEFINE_mInt64(delete_bitmap_store_v2_max_bytes_in_fdb, "89000"); Review Comment: [P2] Keep full V2 reads below the meta-service response cap With this default, every inner bitmap up to 89,000 bytes is returned inline. `sync_tablet_delete_bitmap()` requests all rowsets in one RPC while `enable_batch_get_delete_bitmap` still defaults to false, and the meta-service fails once accumulated `delete_bitmap_byte` exceeds `max_get_delete_bitmap_byte` (1 GiB). `max_tablet_version_num` is a supported mutable setting that the load path explicitly tells operators they may raise; with 12,065 rowsets whose inline payloads are near this threshold, a cold/full sync crosses the cap and the BE cannot load the tablet. Under the old 1,024-byte cutoff, those values were stored in files and the response contained small descriptors instead. Please make V2 reads batch automatically/by default with this larger threshold, or otherwise keep the aggregate inline bound below the response cap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
