CalvinKirs opened a new pull request, #67986:
URL: https://github.com/apache/doris/pull/67986

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: #67545
   
   Problem Summary:
   
   #67545 changed `OssHdfsProperties.validateAndNormalizeUri` to qualify a bare 
bucket authority with the bound oss-dls endpoint host (`oss://bucket/x` -> 
`oss://bucket.<region>.oss-dls.aliyuncs.com/x`), and covered the new behavior 
in `OssHdfsPropertiesTest`. It did not update 
`OssHdfsPropertiesSpiParityTest.testValidateUriOssSchemeOnly`, which still 
asserted the old passthrough, so `fe-filesystem-oss-hdfs` has failed on master 
since:
   
   ```
   OssHdfsPropertiesSpiParityTest.testValidateUriOssSchemeOnly:113
   expected: <oss://mybucket/x> but was: 
<oss://mybucket.cn-hangzhou.oss-dls.aliyuncs.com/x>
   ```
   
   The fe-core oracle the test comment refers to no longer exists on master, so 
the passthrough expectation had nothing left backing it. This PR only updates 
the test: it now asserts the qualified form, its idempotence when the input is 
already qualified under the same endpoint, and keeps the rejection of 
non-`oss://` schemes. No production code is changed.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test
       - [ ] Regression test
       - [x] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason
   
   - Behavior changed:
       - [x] No.
       - [ ] Yes.
   
   - Does this need documentation?
       - [x] No.
       - [ ] Yes.
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to