morrySnow commented on code in PR #67783:
URL: https://github.com/apache/doris/pull/67783#discussion_r4011712921


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java:
##########
@@ -495,9 +497,10 @@ private static LogicalPlan 
checkAndAddDeleteSignFilter(LogicalOlapScan scan, Con
                 scan = scan.withPreAggStatus(PreAggStatus.off(
                         Column.DELETE_SIGN + " is used as conjuncts."));
             }
-            return new LogicalFilter<>(ImmutableSet.of(conjunct), scan);
+            LogicalPlan child = addCheckPolicy ? new 
LogicalCheckPolicy<>(scan) : scan;

Review Comment:
   Fixed in 3fbc4b5a13e. Each MOW branch now builds the delete-sign/commit-TSO 
or binlog-operation reconstruction filters first and wraps the complete chain 
in LogicalCheckPolicy. CheckPolicy peels and combines the full filter chain 
below the data-mask project. The updated CheckRowPolicyTest uses a non-movable 
assert_true mask, also masks the hidden reconstruction columns to force new 
ExprIds, and verifies all three control-slot predicates remain below every 
non-movable mask project. CheckRowPolicyTest passes: 11 tests, 0 
failures/errors/skips.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to