CalvinKirs commented on PR #67970: URL: https://github.com/apache/doris/pull/67970#issuecomment-5676237435
The underlying issue is real, but this PR is not mergeable, and most of this would have surfaced by running the existing tests locally: - Commit `0e794894ed8` adds unrelated `.trae-html-share-packages/*.zip` binaries. - Fails an existing unit test: `MysqlSerializerVarbinaryTest:115 expected: <255> but was: <10>`. - Would fail `prepared_stmt_p0/prepared_stmt_metadata.groovy`: STRING at 65533 becomes `TEXT` instead of `TINYTEXT` in Connector/J. So "Behavior changed: No" is not accurate. - The STRING cap rationale is wrong: `MAX_STRING_LENGTH` fits in 4 bytes, and MySQL LONGTEXT advertises 0xFFFFFFFF. Capping at 65533 makes clients truncate STRING values over 64 KB. - It does not fix the reporter's ODBC case: ODBC computes `length / mbmaxlen`, and Doris advertises charset 33 (mbmaxlen 3), so VARCHAR(1000) still yields 333 chars. Please run the existing tests before requesting review; otherwise this is just noise for reviewers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
