raghav-reglobe commented on PR #67792: URL: https://github.com/apache/doris/pull/67792#issuecomment-5679010816
Both fixed in the follow-up commit, and the PR body is updated to match the code. - **Certificate-only logins.** The refusal is now one shared step, `AuthenticatorManager.refuseIfAccountLocked`, called on the `shouldSkipPasswordVerification()` early return and at the common finish alike, so every path that can open a session runs the same check. `testCertificateOnlyLoginRunsTheSameLockCheck` covers it. - **LDAP branch.** `currentUser.get(0)`, matching every other caller. - **PR body.** Design now describes the shared predicate and every path it covers (local password, LDAP / Flight, integrations, plugins, certificate-only), says what an older binary really does with a `LOCK_ACCOUNT` entry (logs an ERROR for it and stays unlocked, no crash), and the release note mentions that `ACCOUNT_LOCK` / `ACCOUNT_UNLOCK` combined with policy options now errors instead of half-applying, plus the root refusal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
