yiguolei commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r4022103628
##########
be/src/format/transformer/vparquet_transformer.h:
##########
@@ -83,23 +86,27 @@ struct ParquetFileOptions {
TParquetVersion::type parquet_version;
bool parquet_disable_dictionary = false;
bool enable_int96_timestamps = false;
+ // Overrides only INT96 normalization; UTC preserves a wall-clock carrier.
+ std::optional<std::string> int96_timezone = std::nullopt;
};
// a wrapper of parquet output stream
class VParquetTransformer final : public VFileFormatTransformer {
public:
- VParquetTransformer(RuntimeState* state, doris::io::FileWriter*
file_writer,
- const VExprContextSPtrs& output_vexpr_ctxs,
- std::vector<std::string> column_names, bool
output_object_data,
- const ParquetFileOptions& parquet_options,
- const std::string* iceberg_schema_json = nullptr,
- const iceberg::Schema* iceberg_schema = nullptr);
-
- VParquetTransformer(RuntimeState* state, doris::io::FileWriter*
file_writer,
- const VExprContextSPtrs& output_vexpr_ctxs,
- std::vector<TParquetSchema> parquet_schemas, bool
output_object_data,
- const ParquetFileOptions& parquet_options,
- const std::string* iceberg_schema_json = nullptr);
+ VParquetTransformer(
+ RuntimeState* state, doris::io::FileWriter* file_writer,
Review Comment:
把VParquetTransformer 这个类别final 了。 直接继承一个 VParquetTransformer
写一个VIcebergParquetTransformer， 把这堆iceberg 相关的参数移动到新类里实现把
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
