morrySnow commented on code in PR #67822:
URL: https://github.com/apache/doris/pull/67822#discussion_r4024970399
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayEnumerateUniq.java:
##########
@@ -74,6 +75,17 @@ public void checkLegalityBeforeTypeCoercion() {
}
}
}
+ if (getArguments().size() != 1) {
Review Comment:
Fixed in 7905449d58d. Variadic `array_enumerate_uniq` now validates every
array item against the serialized-key-capable scalar set before the BE can
enter `MethodSerialized`. I also added the requested two-array BITMAP negative
regression. The FE build, CheckExpressionLegalityTest, and targeted regression
suite all pass.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArraySort.java:
##########
@@ -62,13 +63,8 @@ private ArraySort(ScalarFunctionParams functionParams) {
public void checkLegalityBeforeTypeCoercion() {
DataType argType = getArgument(0).getDataType();
if (argType instanceof ArrayType) {
- // Find the innermost element type for nested arrays
DataType itemType = ((ArrayType) argType).getItemType();
- while (itemType.isArrayType()) {
- itemType = ((ArrayType) itemType).getItemType();
- }
- if (itemType.isMapType() || itemType.isStructType()
- || itemType.isVariantType() || itemType.isJsonType()) {
+ if
(!ArrayFunctionTypeChecker.isSupportedByArrayComparisonFunctions(itemType)) {
Review Comment:
Fixed in 7905449d58d. The lambda overload now reads the bound source from
`lambda.getLambdaArgument(0).getArrayExpression()` and validates its element
type against the lambda sorter dispatcher support. I also added the BITMAP
lambda-form negative regression. The FE build, CheckExpressionLegalityTest, and
targeted regression suite all pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
