github-actions[bot] commented on code in PR #68124:
URL: https://github.com/apache/doris/pull/68124#discussion_r4034445319
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergScanPlanProvider.java:
##########
@@ -549,7 +549,7 @@ public ConnectorSplitSource streamSplits(ConnectorSession
session, ConnectorTabl
int formatVersion = getFormatVersion(table);
List<String> orderedPartitionKeys =
IcebergPartitionUtils.getIdentityPartitionColumns(table);
ZoneId zone = resolveSessionZone(session);
- boolean partitioned = table.spec().isPartitioned();
+ boolean partitioned = IcebergPartitionUtils.hasPartitionedSpec(table);
Review Comment:
The synchronous regression covers the `planScanInternal` gate, but this lazy
path computes an independent flag and none of the new evolution tests drains
`streamSplits`. Reverting only this line to the current-spec check would still
make batch-mode scans lose the old spec's identity value while every added test
stayed green. Please add one identity-to-unpartitioned case that forces or
validates streaming, drains `streamSplits`, and asserts the partition value,
spec id, and partition JSON.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
