luwei16 commented on PR #68033:
URL: https://github.com/apache/doris/pull/68033#issuecomment-5711592995
Local review conclusion: **PASS**.
Reviewed the exact range
`0aea7140de64a7162d0a0d764e3dc1db7f40dbae...7f743dd43879ab49c9f0482e75fc0dfeba56e02e`.
The change correctly excludes row-binlog tablets only from Cloud
`COMPACTION_POLICY` updates, preserving their dedicated `binlog` policy while
keeping other tablet metadata updates unchanged. I found no PR-introduced
correctness, concurrency, lifecycle, persistence, compatibility, observability,
or performance issue. The new unit tests distinguish the affected and
unaffected paths; exact-head compile, FE UT, P0, Cloud/Vault, NonConcurrent,
External, and Performance checks passed, and incremental FE coverage is 100%.
No local build or tests were run as part of this read-only review.
Non-blocking historical-state note: an old FE may already have persisted an
ordinary policy on row-binlog tablets. That condition predates this PR and is
neither introduced nor worsened here, so it is not counted as a finding; a
separate repair/normalization mechanism would still be useful.
<!-- doris-repo-review:v1:begin -->
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68033
commit: 7f743dd43879ab49c9f0482e75fc0dfeba56e02e
base: 0aea7140de64a7162d0a0d764e3dc1db7f40dbae
reviewed_at: 2026-09-17T16:44:50+08:00
reviewer: luwei16
model: gpt-5.6-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 2
converged: true
```
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
